[Kde-pim] Review Request 121091: KMail: provide UI feedback when waiting for opened message to be retrieved

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121091/#review70177
-----------------------------------------------------------

Ship it!


Seems good for me.
Ship it

- Laurent Montel


On nov. 10, 2014, 10:38 matin, Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121091/
> -----------------------------------------------------------
> 
> (Updated nov. 10, 2014, 10:38 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When you double-click a message, the Viewer will not appear until the ItemFetchJob for the selected message finishes. In some situations, this can take a lot of time (for example when the Session is blocked by another ItemFetchJob, that has triggered folder sync). During this time, user has no information about what is happening, and will probably click the message many times. Once Session is unblocked, the user will end up with dozen Viewers for the same message.
> 
> This patch makes slotMessageActivated() use a KMCommand, which provides a nice UI feedback when operation takes a bit longer, instead of using ItemFetchJob directly.
> 
> 
> Diffs
> -----
> 
>   kmail/kmcommands.h 3a7ac65 
>   kmail/kmcommands.cpp 917fdb6 
>   kmail/kmmainwidget.h 2249740 
>   kmail/kmmainwidget.cpp fb18e16 
> 
> Diff: https://git.reviewboard.kde.org/r/121091/diff/
> 
> 
> Testing
> -------
> 
> The Viewer opens correctly when the ItemFetchJob finishes quickly (without any UI feedback). Comment out the connect()s in kmcommands.cpp on l. 314 and 315 to simulate a long-lasting ItemFetchJob. The "Please wait while the message is transferred" dialog pops up after a while -> user knows what's happening (but of course no Viewer will appear, since the connect() is commented out).
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/