[Kde-pim] Review Request 120520: kioslave: fix typo, clean up

[Daniel Vrátil]

> On Nov. 18, 2014, 2:46 p.m., Daniel Vrátil wrote:
> > Boris, have you submitted this patch, or do you need someone else to push it for you?
> 
> Boris Egorov wrote:
>     Daniel, I don't know what to do after 'Ship It!'. Should I send patch somewhere? I already have contributor rights, so I can merge it into the tree myself.

'Ship it' means that you can push the patch to git. Append "REVIEW: 120520" line to the commit message and this review will closed automatically.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120520/#review70585
-----------------------------------------------------------


On Oct. 7, 2014, 12:58 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120520/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 12:58 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Add missing parenthesis, remove unused member variables, make not changing parameters const
> 
> 
> Diffs
> -----
> 
>   kioslave/src/pop3/pop3.h 336bb1d 
>   kioslave/src/pop3/pop3.cpp 8b42218 
>   kioslave/src/ldap/kio_ldap.h 5895617 
>   kioslave/src/ldap/kio_ldap.cpp 6706134 
> 
> Diff: https://git.reviewboard.kde.org/r/120520/diff/
> 
> 
> Testing
> -------
> 
> Haven't done yet.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/