[Kde-pim] Review Request 120865: Coding Style for address.h addressee.h addresseehelper.h addresseelist.h contactgroup.h contactgrouptool.h errorhandler.h field.h geo.h key.h ldifconverter.h phonenumber.h picture.h plugin.h secrecy.h sortmode.h sound.h timezone.h vcardconverter.h vcarddrag.h vcardtool.h

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120865/#review69971
-----------------------------------------------------------

Ship it!


Just a small nitpicks regarding argument names. Just fix it before committing, no need for another review. Thanks!


kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120865/#comment48955>

    "other" is more commonly used variable name in the "operator" methods



kabc/src/addressee.h
<https://git.reviewboard.kde.org/r/120865/#comment48956>

    adressee -> other



kabc/src/picture.h
<https://git.reviewboard.kde.org/r/120865/#comment48957>

    picture -> other



kabc/src/timezone.h
<https://git.reviewboard.kde.org/r/120865/#comment48958>

    timezone -> other



kabc/src/timezone.h
<https://git.reviewboard.kde.org/r/120865/#comment48959>

    timezone -> other


- Dan Vrátil


On Oct. 30, 2014, 9:33 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120865/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:33 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Krammer, Laurent Montel, and Tobias Koenig.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   kabc/src/addresseelist.h 4ffe8db037659b6e6d26931b157eb058b0ca02b8 
>   kabc/src/sound.h 2a7d205 
>   kabc/src/timezone.h 8311c5b047905ddf1ce40e487430314123554713 
>   kabc/src/vcardconverter.h 4c19d0f 
>   kabc/src/vcarddrag.h 11e0f4b 
>   kabc/src/vcardtool.h 25a95e5 
>   kabc/src/ldifconverter.h d12bdbf 
>   kabc/src/phonenumber.h cab5d6b8bafe51d4d6fc568a5251c5024cf8c1ef 
>   kabc/src/picture.h 3e9780f075d574e59b4b9a24c687f43d1172aafc 
>   kabc/src/plugin.h 1f9005e 
>   kabc/src/secrecy.h 33108b1779b410a2ad238714e64880623bf4317a 
>   kabc/src/sortmode.h 36be9c8 
>   kabc/src/field.h f9178680a079c423ebd1ab85b8259ee190ba184b 
>   kabc/src/geo.h 5d675623503082e89b8494b9fdb67a5f2266e398 
>   kabc/src/key.h 8a1fbb9f5dc300479b8a896cd2e95d9828e789a5 
>   kabc/src/contactgroup.h 2a7a6957546fe11cf98e4412f44b62f821017057 
>   kabc/src/contactgrouptool.h 83c8a91 
>   kabc/src/errorhandler.h 6a421dc 
>   kabc/src/address.h de079a6 
>   kabc/src/addressee.h baa9e997fdb791b4d3381d34a4da019038176d0b 
>   kabc/src/addresseehelper.h 84dad2a 
> 
> Diff: https://git.reviewboard.kde.org/r/120865/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/