[Kde-pim] Review Request 121034: Port away from KPimUtils::KFileIO

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121034/#review70178
-----------------------------------------------------------


Seems good.
We can't be sure that all is ok because we don't have unittest bug seems good.
Ship it

- Laurent Montel


On nov. 10, 2014, 8:46 matin, Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121034/
> -----------------------------------------------------------
> 
> (Updated nov. 10, 2014, 8:46 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Replace usage of KFileIO by simple QFile.open(), QFile.{read,write}(), QFile.close() + some error handling.
> 
> This is the first step to kill KPimUtils.
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/urlhandlermanager.cpp 85ec457 
>   messageviewer/viewer/viewer_p.cpp 8aa8a3f 
>   plugins/messageviewer/bodypartformatter/ms-tnef/CMakeLists.txt dde7baa 
>   plugins/messageviewer/bodypartformatter/ms-tnef/application_ms-tnef.cpp 8d6ee05 
>   kmail/kmkernel.cpp 6abb4f7 
>   kontact/src/mainwindow.cpp b3edbe6 
>   mailcommon/filter/filteractionwithcommand.cpp 8884526 
>   mailimporter/CMakeLists.txt 002eee4 
>   mailimporter/filters.cpp 3e58631 
>   messagecomposer/attachment/attachmentcontrollerbase.cpp dfb5b7e 
>   messagecomposer/attachment/attachmentmodel.cpp c496acb 
>   messageviewer/CMakeLists.txt 7c553c7 
>   messageviewer/viewer/nodehelper.cpp 4d0d57a 
>   akregator/src/CMakeLists.txt 3c1f1bd 
>   akregator/src/articleviewer.cpp d6eccc3 
>   kmail/CMakeLists.txt b08e7b4 
>   kmail/kmcommands.cpp bc6f2ae 
> 
> Diff: https://git.reviewboard.kde.org/r/121034/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/