[Kde-pim] Review Request 119576: how to protect a command from a change by using astyle

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119576/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 6:39 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM and Dan Vrátil.


Repository: akonadi


Description
-------

astyle cannot (yet) distinguite a hythen from a minus character.
Using a "string" such as X-AKAPPEND in the macro MAKE_CMD_ROW is a problem.
astyle surounds the - with spaces.
I propose to use a second macro MAKE_CMD_ROW2 providing the string as "X-AKAPPEND".
It might be prettier to do this for all the commands.

The problem could also happens for the commands:
X-AKLIST and X-AKLSUB


Diffs
-----

  server/tests/unittest/handlertest.cpp 6fc5d66 

Diff: https://git.reviewboard.kde.org/r/119576/diff/


Testing
-------


Thanks,

Guy Maurel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/