[Kde-pim] Review Request 121255: Intern entity strings for table and column names.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121255/
-----------------------------------------------------------

(Updated Nov. 28, 2014, 10:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi, Daniel Vrátil and Volker Krause.


Repository: akonadi


Description
-------

This should drastically cut down on the amount of allocations done
by the AkonadiServer. Currently, the getters will do the conversion
from QLatin1String to QString on every call. By reusing the data
via a function-local static const QString object, we can eliminate
all of these allocations and increase the cache locality as well.


Diffs
-----

  server/src/storage/entities-source.xsl 174cf4f718a0a0897c8dfa31cb580ab377bbf5a1 
  server/src/storage/entities.xsl 033e292927ae673d95f708d50572c326d6da73bd 

Diff: https://git.reviewboard.kde.org/r/121255/diff/


Testing
-------

Tests all pass, and KMail with a restarted Akonadi is still happy (no runtime errors that I can notice).

Perf shows that the string allocations are mostly gone now.


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/