[Kde-pim] Review Request 121096: fix compilation failure when -DQT_NO_DEBUG_OUTPUT

[René J.V. Bertin]

> On Nov. 10, 2014, 5:08 p.m., Laurent Montel wrote:
> > As you wrote it's just a workaround.
> > You need to find why you have this error.
> > For example post the error.
> > We can't just add this workaround.
> > 
> > Regards
> 
> René J.V. Bertin wrote:
>     I have this error because I compile with -DQT_NO_DEBUG_OUTPUT . Given the complexity of the kind of object one can << into qDebug() I'm not even going to try to understand what function of what class messes up; that's up to a regular kdepim or kdepimlibs developer who knows his or her way around the code. All I could do is replace credentialsData with a void stub function when QT_NO_DEBUG_OUTPUT is defined, and that's not any more or less a workaround.
>     
>     In fact, someone of you ought to try a build with this flag defined, because a comparable error also popped up at resources/imap/subscriptiondialog.cpp:376
> 
> Laurent Montel wrote:
>     I think that it's not supported.
>     Indeed kdepim-runtime reports a lot of compile error with it.
>     We will not add a #ifdef... in each kDebug()<< KDateTime/QVAriant etc in code
>     Nobody tried it previously. So not necessary to lose time against it.
>     kdelibs compiles with this flag ?

At least akonadi builds with this flag; for kdelibs I've never tried. Isn't required either because it adheres to the guideline of not outputting loads and loads of messages when debug output is switched off through kdebugdialog.
That is NOT the case with kdepim-runtime (and akonadi), as came up on the kdepim-user ML very recently.

As far as I'm concerned I made this RR mostly to bring the issue to attention. If not adhering to guidelines, log pollution, waste of CPU cycles and storing potentially sensitive information in places like ~/.Xsession-errors are of no concern to you ... well, I can simply offer my patches to Ubuntu and MacPorts for downstream application.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121096/#review70198
-----------------------------------------------------------


On Nov. 10, 2014, 5:03 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121096/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 5:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> resources/dav/resource/settings.cpp has an issue in Settings::accountsUsername that causes compilation to fail when -DQT_NO_DEBUG_OUTPUT. The real issue may in fact lie in the definition GetCredentialsJob::credentialsData; the patch provided here implements a workaround.
> 
> 
> Diffs
> -----
> 
>   resources/dav/resource/settings.cpp 1d32418 
> 
> Diff: https://git.reviewboard.kde.org/r/121096/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04 with kdelibs 4.14.2 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/