[Kde-pim] Review Request 121017: don't update KMMainWidget's folderMenu when shutting down

[René J.V. Bertin]

> On Nov. 7, 2014, 7:42 a.m., Laurent Montel wrote:
> > Perhaps there is an other method that add it for each call no ?
> 
> René J.V. Bertin wrote:
>     Other than a manual method where someone does if and when a crash has identified an unprotected call, I really wouldn't know how to do that. Mopping with the tap open, as we say in the Netherlands.
>     
>     Someone who knows KMail's event handling skeleton well (as well as undoubtedly of the other PIM components) should be able to add those few lines to the relevant SLOT functions quite easily.
>     
>     I've checked `KJob::exec`: it calls a QEventLoop `eventLoop->exec(QEventLoop::ExcludeUserInputEvents)` which means that if we get those UI events in error, it's an upstream error in Qt. I've asked on Qt's interest ML about that.

Oh, and in the meantime I haven't yet had the occasion to check whether this patch does its work... (not that there's any reason to expect it wouldn't, except if `kmkernel` evaluates to a NULL pointer)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121017/#review69963
-----------------------------------------------------------


On Nov. 6, 2014, 8:19 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121017/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 8:19 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Under certain conditions UI events come through when shutting down Kontact or KMail, for instance during `jobStatistics->exec()` in `KMKernel::cleanup`. 
> When that leads to an attempted update of the folder menu, the process will crash because it accesses already released resources.
> See bug report https://bugs.kde.org/show_bug.cgi?id=340680
> 
> This patch prevents the illegal access highlighted in the above bugreport.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 8296b4a 
> 
> Diff: https://git.reviewboard.kde.org/r/121017/diff/
> 
> 
> Testing
> -------
> 
> On Kubuntu 14.04 with kdelibs 4.14.2 and kdepim git/4.14.3 .
> On OS X Mac OS 10.6.8 with kdelibs git/4.14 and kdepim 4.14.2 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/