[Kde-pim] Review Request 121017: don't update KMMainWidget's folderMenu when shutting down

René J.V. Bertin rjvbertin at gmail.com
Thu Nov 6 19:19:22 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121017/
-----------------------------------------------------------

Review request for KDEPIM.


Repository: kdepim


Description
-------

Under certain conditions UI events come through when shutting down Kontact or KMail, for instance during `jobStatistics->exec()` in `KMKernel::cleanup`. 
When that leads to an attempted update of the folder menu, the process will crash because it accesses already released resources.
See bug report https://bugs.kde.org/show_bug.cgi?id=340680

This patch prevents the illegal access highlighted in the above bugreport.


Diffs
-----

  kmail/kmmainwidget.cpp 8296b4a 

Diff: https://git.reviewboard.kde.org/r/121017/diff/


Testing
-------

On Kubuntu 14.04 with kdelibs 4.14.2 and kdepim git/4.14.3 .
On OS X Mac OS 10.6.8 with kdelibs git/4.14 and kdepim 4.14.2 .


Thanks,

René J.V. Bertin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list