[Kde-pim] Review Request 121096: convert qDebug and qWarning to kDebug and kWarning

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121096/#review70245
-----------------------------------------------------------



agents/newmailnotifier/newmailnotifiershowmessagejob.cpp
<https://git.reviewboard.kde.org/r/121096/#comment49117>

    ?????? kFatal ?????


- Laurent Montel


On nov. 11, 2014, 3:53 après-midi, René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121096/
> -----------------------------------------------------------
> 
> (Updated nov. 11, 2014, 3:53 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This patch does as said in the summary. Rationale is to avoid log pollution, storing potentially sensitive data in unexpected locations and waste of CPU cycles.
> First impressions are that disabling debug output (which is now under kdebugdialog control) does indeed make KMail considerably "snappier" (at least when combined with akonadi built with -DQT_NO_DEBUG_OUTPUT).
> 
> This also makes kdepim-runtime adhere more closely to KDE debugging output guidelines.
> 
> 
> Diffs
> -----
> 
>   qml/kde/tests/qml_moves/mainwindow.cpp 1324575 
>   qml/kde/tests/qmlbreadcrumbnavigation/checkableitemproxymodel.cpp f61485a 
>   qml/kde/tests/qmlbreadcrumbnavigation/kmodelindexproxymapper.cpp c464938 
>   qml/kde/tests/qmlbreadcrumbnavigation/kproxyitemselectionmodel.cpp 6d176fb 
>   qml/kde/tests/qmlbreadcrumbnavigation/qmllistselectionmodel.cpp dbc794e 
>   resources/imap/tests/testsubscriptiondialog.cpp 9653b76 
>   resources/kolabproxy/kolabhandler.cpp 0574464 
>   resources/kolabproxy/upgradejob.cpp 74f80fe 
>   resources/maildir/libmaildir/maildir.cpp 9ad4a66 
>   resources/mixedmaildir/kmindexreader/tests/testidxreader.cpp d51cc9d 
>   agents/newmailnotifier/newmailnotifiershowmessagejob.cpp cbbcbed 
>   qml/kde/kdeintegrationplugin.cpp c1360b4 
>   qml/kde/tests/qml_moves/dynamictreemodel.cpp 5537bb7 
>   resources/mixedmaildir/tests/itemfetchtest.cpp 5372ce5 
>   resources/openxchange/openxchangeresource.cpp 377b908 
>   resources/openxchange/oxa/incidenceutils.cpp 1f0592b 
>   resources/pop3/tests/fakeserver/fakeserver.cpp 2201045 
>   resources/pop3/tests/pop3test.cpp f6b0f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/121096/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04 with kdelibs 4.14.2 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/