[Kde-pim] Review Request 121015: Port KAbc -> KContacts

Aleix Pol Gonzalez aleixpol at kde.org
Thu Nov 6 18:06:40 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121015/
-----------------------------------------------------------

Review request for KDEPIM.


Repository: kdepim


Description
-------

Applied the script, small fix in a weird ifdef.


Diffs
-----

  plugins/ktexteditor/CMakeLists.txt 6be853d 
  plugins/ktexteditor/ktexteditorkabcbridge.cpp a646dcc 
  plugins/messageviewer/bodypartformatter/vcard/CMakeLists.txt 5c1b7c2 
  plugins/messageviewer/bodypartformatter/vcard/text_vcard.cpp ee02cc0 
  plugins/messageviewer/bodypartformatter/vcard/updatecontactjob.h 3e60864 
  plugins/messageviewer/bodypartformatter/vcard/updatecontactjob.cpp 6a12274 
  plugins/messageviewer/bodypartformatter/vcard/vcardmemento.h 010b074 
  plugins/messageviewer/bodypartformatter/vcard/vcardmemento.cpp 4c7a6c8 
  importwizard/abstractaddressbook.h dba3d54 
  importwizard/abstractaddressbook.cpp a15d341 
  importwizard/balsa/balsaaddressbook.cpp 8cf6f03 
  importwizard/opera/operaaddressbook.h 6068e4d 
  importwizard/opera/operaaddressbook.cpp 2270014 
  importwizard/sylpheed/sylpheedaddressbook.cpp 1de49cd 
  importwizard/thunderbird/thunderbirdaddressbook.cpp 1c07a12 
  importwizard/thunderbird/thunderbirdsettings.cpp b2c0e7d 
  importwizard/trojita/trojitaaddressbook.cpp 1a3aeff 
  incidenceeditor-ng/incidenceattachment.cpp 023f60e 
  incidenceeditor-ng/incidenceattendee.h c7ba4e5 
  incidenceeditor-ng/incidenceattendee.cpp edda470 
  incidenceeditor-ng/incidencedefaults.cpp f8d8e76 
  kaddressbook/CMakeLists.txt 53e4aa7 
  kaddressbook/autotests/CMakeLists.txt 0213552 
  kaddressbook/autotests/contactfieldstest.cpp 366b3e9 
  kaddressbook/categoryfilterproxymodel.cpp b1e7a77 
  kaddressbook/contactfields.h 3bc1705 
  kaddressbook/contactfields.cpp d3bce18 
  kaddressbook/contactselectiondialog.h 7392b17 
  kaddressbook/contactselectiondialog.cpp f3cdd53 
  kaddressbook/contactselectionwidget.h 22abb27 
  kaddressbook/contactselectionwidget.cpp 647b663 
  kaddressbook/contactsorter.h 1d99659 
  kaddressbook/contactsorter.cpp d3d3aab 
  kaddressbook/globalcontactmodel.cpp 0c3e2a7 
  kaddressbook/mainwidget.cpp 7d69512 
  kaddressbook/merge/autotests/CMakeLists.txt b153eb9 
  kaddressbook/merge/autotests/mergecontactshowresultdialogtest.cpp b7fa475 
  kaddressbook/merge/autotests/mergecontacttest.cpp 7fb8563 
  kaddressbook/merge/autotests/mergecontactwidgettest.cpp f6d233b 
  kaddressbook/merge/autotests/searchpotentialduplicatecontactjobtest.cpp 2c7235c 
  kaddressbook/merge/mergecontacts.h 9c15fa5 
  kaddressbook/merge/mergecontacts.cpp 69d5e54 
  kaddressbook/merge/mergecontactshowresultdialog.cpp d1eb6c1 
  kaddressbook/merge/mergecontactshowresulttabwidget.cpp cd30d64 
  kaddressbook/merge/mergecontactsjob.h a95dcb3 
  kaddressbook/merge/mergecontactsjob.cpp 2489824 
  kaddressbook/merge/mergecontactutil.cpp 04f141e 
  kaddressbook/merge/mergecontactwidget.cpp c21a0f8 
  kaddressbook/merge/mergecontactwidgetlist.h 8922390 
  kaddressbook/merge/mergecontactwidgetlist.cpp d1f0164 
  kaddressbook/merge/searchpotentialduplicatecontactjob.cpp fbd1aaa 
  kaddressbook/modelcolumnmanager.cpp efab91c 
  kaddressbook/printing/compact/compactstyle.h 3a53ca7 
  kaddressbook/printing/compact/compactstyle.cpp 12658d0 
  kaddressbook/printing/detailled/detailledstyle.h de3b43e 
  kaddressbook/printing/detailled/detailledstyle.cpp 6d4f32d 
  kaddressbook/printing/grantlee/contactgrantleeprintaddressobject.h 7352049 
  kaddressbook/printing/grantlee/contactgrantleeprintaddressobject.cpp 9ad5d03 
  kaddressbook/printing/grantlee/contactgrantleeprintcryptoobject.h 238c7fb 
  kaddressbook/printing/grantlee/contactgrantleeprintcryptoobject.cpp 3cfc1b0 
  kaddressbook/printing/grantlee/contactgrantleeprintgeoobject.h 71d9c25 
  kaddressbook/printing/grantlee/contactgrantleeprintgeoobject.cpp 8b66da2 
  kaddressbook/printing/grantlee/contactgrantleeprintobject.h 8efea2d 
  kaddressbook/printing/grantlee/contactgrantleeprintobject.cpp 444f67d 
  kaddressbook/printing/grantlee/contactgrantleeprintphoneobject.h a787ccf 
  kaddressbook/printing/grantlee/contactgrantleeprintphoneobject.cpp 006cdb2 
  kaddressbook/printing/grantlee/grantleeprintstyle.h b2db0c7 
  kaddressbook/printing/grantlee/grantleeprintstyle.cpp 49feb9d 
  kaddressbook/printing/mike/mikesstyle.h 5c64e5c 
  kaddressbook/printing/mike/mikesstyle.cpp a6b5e59 
  kaddressbook/printing/printingwizard.h 207db24 
  kaddressbook/printing/printingwizard.cpp c7f02b3 
  kaddressbook/printing/printstyle.h ee5572c 
  kaddressbook/printing/ringbinder/ringbinderstyle.h 2010491 
  kaddressbook/printing/ringbinder/ringbinderstyle.cpp 4f33295 
  kaddressbook/sendmail/autotests/CMakeLists.txt 07c1564 
  kaddressbook/sendmail/autotests/mailsenderjobtest.cpp 3fa7f41 
  kaddressbook/sendmail/mailsenderjob.cpp 91ac786 
  kaddressbook/utils.cpp 456cafe 
  kaddressbook/xxport/csv/csv_xxport.h 0865321 
  kaddressbook/xxport/csv/csv_xxport.cpp 2e92236 
  kaddressbook/xxport/csv/csvimportdialog.h b349df1 
  kaddressbook/xxport/csv/csvimportdialog.cpp bae4273 
  kaddressbook/xxport/gmx/gmx_xxport.h 55eb3c4 
  kaddressbook/xxport/gmx/gmx_xxport.cpp 89df96f 
  kaddressbook/xxport/ldap/ldap_xxport.h a42a6d0 
  kaddressbook/xxport/ldap/ldap_xxport.cpp b898dc1 
  kaddressbook/xxport/ldif/ldif_xxport.h b8401e4 
  kaddressbook/xxport/ldif/ldif_xxport.cpp fc85a93 
  kaddressbook/xxport/shared/xxport.h b14dd82 
  kaddressbook/xxport/shared/xxport.cpp 81c59cb 
  kaddressbook/xxport/vcard/vcard_xxport.h d8d6620 
  kaddressbook/xxport/vcard/vcard_xxport.cpp 0bdea28 
  kaddressbook/xxportmanager.h fc67dc7 
  kaddressbook/xxportmanager.cpp 3d3cb80 
  kaddressbookgrantlee/CMakeLists.txt ebc2c63 
  kaddressbookgrantlee/formatter/grantleecontactformatter.cpp fd46b50 
  kaddressbookgrantlee/formatter/grantleecontactgroupformatter.cpp fcf7294 
  kalarm/CMakeLists.txt c7a15f6 
  kalarm/birthdaymodel.cpp 28dd262 
  kalarm/lib/lineedit.cpp 3ce792b 
  kmail/CMakeLists.txt 5947767 
  kmail/dialog/addemailtoexistingcontactdialog.cpp 3ff3d3e 
  kmail/editor/attachmentcontroller.cpp c9790be 
  kmail/editor/kmcomposereditor.cpp 1a6348b 
  kmail/editor/kmcomposewin.cpp fcd6ecb 
  kmail/identity/identityeditvcarddialog.cpp e47b231 
  kmail/identity/xfaceconfigurator.cpp 0334b0d 
  kmail/job/addemailtoexistingcontactjob.cpp 21c0546 
  kmail/job/createnewcontactjob.cpp debae95 
  kmail/kmreaderwin.h 629c15e 
  kmail/kmreaderwin.cpp 71f72f8 
  kontact/plugins/kmail/kmail_plugin.cpp 056454c 
  kontact/plugins/knotes/knotes_plugin.cpp fcbf900 
  kontact/plugins/korganizer/CMakeLists.txt f3e1994 
  kontact/plugins/korganizer/korganizerplugin.cpp 047bacd 
  kontact/plugins/korganizer/todoplugin.cpp 1e738ba 
  kontact/plugins/specialdates/CMakeLists.txt fe45822 
  kontact/plugins/specialdates/sdsummarywidget.cpp 3915eb9 
  korganizer/CMakeLists.txt ae1c433 
  korganizer/htmlexportjob.cpp b90cbac 
  libkdepim/CMakeLists.txt 83fa991 
  libkdepim/addressline/addresseelineedit.h b44ce71 
  libkdepim/addressline/addresseelineedit.cpp 5cc78bb 
  libkdepim/addressline/completionordereditor.cpp 380e70d 
  libkdepim/addressline/recentaddresses.h 18654b6 
  libkdepim/addressline/recentaddresses.cpp f2374d2 
  libkdepim/job/addcontactjob.h 8dcf080 
  libkdepim/job/addcontactjob.cpp 53dd2d8 
  libkdepim/job/addemailaddressjob.cpp 9695f9a 
  libkdepim/job/addemaildisplayjob.cpp 4c8528a 
  libkdepim/job/openemailaddressjob.cpp 6337c18 
  libkdepim/ldap/ldapsearchdialog.h 51bf659 
  libkdepim/ldap/ldapsearchdialog.cpp 984dbbc 
  libkdepim/widgets/selectedcollectiondialog.cpp a545d23 
  mailcommon/filter/filteractionaddtoaddressbook.cpp 6011655 
  mailcommon/search/searchpattern.cpp 140cdc5 
  messagecomposer/composer/composerlineedit.cpp e1ad1c0 
  messagecomposer/composer/keyresolver.cpp c0961ba 
  messagecomposer/composer/savecontactpreferencejob.h 1e6947f 
  messagecomposer/composer/savecontactpreferencejob.cpp 5172d9f 
  messagecomposer/job/aliasesexpandjob.cpp f8a484c 
  messagecomposer/recipient/distributionlistdialog.cpp 7f14e42 
  messagecomposer/recipient/recipientspicker.h 029b923 
  messagecomposer/recipient/recipientspicker.cpp f89aefd 
  messagecore/CMakeLists.txt 181a11f 
  messageviewer/CMakeLists.txt cc5b571 
  messageviewer/header/contactdisplaymessagememento.h 03abe38 
  messageviewer/header/contactdisplaymessagememento.cpp 3d73fbd 
  messageviewer/viewer/urlhandlermanager.cpp 78db50d 
  messageviewer/viewer/viewer_p.cpp b469ea0 
  messageviewer/widgets/vcardviewer.h 1d31532 
  messageviewer/widgets/vcardviewer.cpp 18cadf0 
  mobile/contacts/CMakeLists.txt 53537ad 
  mobile/contacts/contactcompletionmodel.cpp 582454b 
  mobile/contacts/contacteditorview.cpp 3852388 
  mobile/contacts/contactgroupeditorview.cpp 7874d8f 
  mobile/contacts/contactlistproxy.cpp e48fe88 
  mobile/contacts/contactsexporthandler.cpp c4091b9 
  mobile/contacts/contactsimporthandler.cpp 273f1e6 
  mobile/contacts/displaynameeditwidget.h 5698890 
  mobile/contacts/displaynameeditwidget.cpp 26731d6 
  mobile/contacts/editorbase.h 3164dab 
  mobile/contacts/editorbusiness.h c536a33 
  mobile/contacts/editorbusiness.cpp bbb947e 
  mobile/contacts/editorcontactgroup.h aece9d4 
  mobile/contacts/editorcontactgroup.cpp 57a57f5 
  mobile/contacts/editorcrypto.h 1182d91 
  mobile/contacts/editorcrypto.cpp 733483e 
  mobile/contacts/editorgeneral.h c01c8a9 
  mobile/contacts/editorgeneral.cpp cef9461 
  mobile/contacts/editorlocation.h 5dc906a 
  mobile/contacts/editorlocation.cpp e8ff21c 
  mobile/contacts/editormore.h 58a1d9a 
  mobile/contacts/editormore.cpp 294006f 
  mobile/contacts/imagewidget.h 2d72b2d 
  mobile/contacts/imagewidget.cpp 233e2f7 
  mobile/contacts/locationmodel.h e9b10a8 
  mobile/contacts/locationmodel.cpp 657aa52 
  mobile/contacts/mainview.cpp 97969f3 
  mobile/contacts/namepartseditwidget.h 6a3453b 
  mobile/contacts/namepartseditwidget.cpp c5250b3 
  mobile/contacts/phonetypecombo.h ecfc00c 
  mobile/contacts/phonetypecombo.cpp db359e0 
  mobile/contacts/searchwidget.cpp a413e35 
  pimcommon/CMakeLists.txt 03af580 
  pimcommon/acl/aclmanager.cpp 0b3d14f 
  pimsettingexporter/pimsettingexporterkernel.cpp ee62161 
  plugins/kaddressbook/editorpages/CMakeLists.txt 915b6fc 
  plugins/kaddressbook/editorpages/cryptopageplugin.h 4b825a8 
  plugins/kaddressbook/editorpages/cryptopageplugin.cpp fad9615 
  CMakeLists.txt 5b5c199 
  akonadi_next/CMakeLists.txt 70d6a1c 
  akonadi_next/amazingdelegate.cpp 146c924 
  akonadiconsole/akonadibrowsermodel.cpp 407a31a 
  akonadiconsole/browserwidget.cpp 9c28d61 
  calendarviews/agenda/agendaitem.cpp eec2440 
  examples/coisceim/mixedtreemodel.cpp 73c8c38 
  examples/etm_usage/CMakeLists.txt 9b739a0 
  examples/etm_usage/mixedtreemodel.cpp 5aebed3 
  examples/etm_usage/recursiveitemlistwidget.cpp d89c392 
  grantleeeditor/contactthemeeditor/contactconfigurationdialog.cpp e15be1a 
  grantleeeditor/contactthemeeditor/contactpreviewwidget.h f134e44 
  grantleeeditor/contactthemeeditor/contactpreviewwidget.cpp 0dea73c 

Diff: https://git.reviewboard.kde.org/r/121015/diff/


Testing
-------

Builds.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list