[Kde-pim] Review Request 118100: Make GETMETADATA RFC 5464 compatiple

Mon May 12 17:44:36 BST 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118100/
-----------------------------------------------------------

(Updated May 12, 2014, 4:44 p.m.)

Review request for KDEPIM-Libraries.

Changes
-------

* Moved getmetadata-option in front of mailbox.
* merged all options into one pair of brackets.

Repository: kdepimlibs

Description
-------

Make GETMETADATA RFC 5464 compatiple and "fixing" ANNOTATEMORE mode.

There were some issues, so the GETMETADATA command was not ok according to RFC 5464.
The ANNOTATEMORE mode is only the draft of RFC 5464, so this is only a legacy mode.
I would say, kimap uses http://tools.ietf.org/html/draft-daboo-imap-annotatemore-06.

Diffs (updated)
-----

  kimap/tests/getmetadatajobtest.cpp 760aab341086be931c1b120df92ba37c20ac28c3 
  kimap/getmetadatajob.cpp 8c13fbb38c9d248fd3502a40e4ca3187b943b630 

Diff: https://git.reviewboard.kde.org/r/118100/diff/

Testing
-------

Adding tests to make sure that GETMETADATA is send in the correctly.
Added tests for ANNOTATEMORE mode.

Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/