[Kde-pim] Review Request 117854: ItemSync: Use serverside merging.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117854/#review56972
-----------------------------------------------------------



akonadi/itemsync.h
<https://git.reviewboard.kde.org/r/117854/#comment39710>

    AKONADI_DEPRECATED



akonadi/itemsync.cpp
<https://git.reviewboard.kde.org/r/117854/#comment39711>

    Shouldn't this be 
    
    } else if (mIncremental) { 
    
    not to enter this path at all during non-incremental sync?


- Dan Vrátil


On April 29, 2014, 11:28 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117854/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 11:28 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemSync: Use serverside merging.
> 
> Instead of fetching all local items to check for changes, to then write modified items
> back to the server, we use the serverside merging instead.
> Additionally this patch allows to merge by gid instead of rid, simply by setting
> the gid additionally to the rid.
> By using the serverside merging, the code could be simplified and we only need
> to fetch the local items anymore to detect removed items when doing a full
> listing.
> 
> This patch renders ItemSync::updateItem useless, but that should be ok as
> I couldn't find a single subclass of ItemSync, and I really don't
> expect there to be one out there.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemsync.h ab409f31e5391e1284fd61d653bee1f28318993d 
>   akonadi/itemsync.cpp 034226ca288fad85ac5d55dffd5e91d5e4a96a29 
>   akonadi/tests/itemsynctest.cpp 2a2e22fcb47442a2b99dbf7fec978363d329c484 
> 
> Diff: https://git.reviewboard.kde.org/r/117854/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/