[Kde-pim] Review Request 118363: Rename and move 'Enable Disconnected Mode' option in IMAP resource configuration

Torsten Grote grote at kolabsys.com
Wed May 28 10:08:07 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118363/#review58628
-----------------------------------------------------------


I think this change makes a whole lot of sense. Thanks for this, Dan!

- Torsten Grote


On May 27, 2014, 8:02 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118363/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 8:02 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This patch renames "Enable Disconnected Mode" option in IMAP configuration dialog to "Download all messages for offline use" and moves the checkbox from "Advanced" tab to "General".
> 
> The reasoning behind this change is, that "Disconnected mode" is not really a clear term to users, while "Download all messages for offline use" perfectly describes what that feature does in a way that every user will understand. Secondly I don't think that this is an "Advanced" feature. I think it's a pretty damn important feature that people usually want to be able to enable, so I think it should be in the "General" tab.
> 
> 
> Diffs
> -----
> 
>   resources/imap/setupserverview_desktop.ui eb749ee 
>   resources/imap/setupserverview_mobile.ui 135ca16 
> 
> Diff: https://git.reviewboard.kde.org/r/118363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list