[Kde-pim] Review Request 118103: tag modifications (e.g. rename) are not propagated through TagModelPrivate::monitoredTagChanged()

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118103/#review57842
-----------------------------------------------------------


Thank you for the patch! The code itself is OK, just update the patch please to match the KDE PIM coding style (see comments below).



akonadi/tagmodel_p.cpp
<https://git.reviewboard.kde.org/r/118103/#comment40258>

    const int



akonadi/tagmodel_p.cpp
<https://git.reviewboard.kde.org/r/118103/#comment40259>

    Spaces around the "!=" operator
    
    if (...) {
      ...
    }
    
    
    


- Dan Vrátil


On May 12, 2014, 6:23 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118103/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 6:23 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> I've been trying to implement a tag renaming operation, using an Akonadi::TagModifyJob.  This appears to work, and the change propagates to the Akonadi::TagModel where TagModelPrivate::monitoredTagChanged() gets called as intended.
> 
> There appears to be a problem here, though, in the usual case where the tag is not being reparented.  The mTags hash is updated, but the mChildTags list for the parent is not.  This means that TagModel::data(), which fetches the tag from the mChildTags hash using tagForIndex(), still returns the old data value and the change appears to have no effect.
> 
> 
> Diffs
> -----
> 
>   akonadi/tagmodel_p.cpp 0f6d5bb 
> 
> Diff: https://git.reviewboard.kde.org/r/118103/diff/
> 
> 
> Testing
> -------
> 
> Built kdepimlibs with this change, tested tag modification - the change is propagated correctly.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/