[Kde-pim] Review Request 118368: Coding Style for collectionqueryhelper.h countquerybuilder.h datastore.h dbconfig.h dbconfigmysql.h dbconfigpostgresql.h dbconfigsqlite.h dbexception.h dbinitializer.h dbinitializer_p.h dbintrospector.h dbintrospector_impl.h dbtype.h dbupdater.h entity.h itemqueryhelper.h itemretrievaljob.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118368/#review58627
-----------------------------------------------------------



server/src/storage/parthelper.h
<https://git.reviewboard.kde.org/r/118368/#comment40820>

    Move this to the line above please



server/src/storage/storagedebugger.h
<https://git.reviewboard.kde.org/r/118368/#comment40821>

    { on a new line



server/src/storage/storagedebugger.h
<https://git.reviewboard.kde.org/r/118368/#comment40822>

    Move { on new line


- Dan Vrátil


On May 28, 2014, 10:53 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118368/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 10:53 a.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   server/src/storage/collectionqueryhelper.h cdaaaf9 
>   server/src/storage/countquerybuilder.h 2269f57 
>   server/src/storage/datastore.h 0600cba 
>   server/src/storage/dbconfig.h 9b75e2b 
>   server/src/storage/dbconfigmysql.h 77b3cc1 
>   server/src/storage/dbconfigpostgresql.h cb3d618 
>   server/src/storage/dbconfigsqlite.h 0070e97 
>   server/src/storage/dbexception.h 586ae44 
>   server/src/storage/dbinitializer.h c5b8556 
>   server/src/storage/dbinitializer_p.h 4af9377 
>   server/src/storage/dbintrospector.h 49ef3ed 
>   server/src/storage/dbintrospector_impl.h d076b3d 
>   server/src/storage/dbtype.h 3595604 
>   server/src/storage/dbupdater.h 0e0daba 
>   server/src/storage/entity.h b1a074e 
>   server/src/storage/itemqueryhelper.h eeee136 
>   server/src/storage/itemretrievaljob.h 2650548 
>   server/src/storage/itemretrievalmanager.h b8ad30e 
>   server/src/storage/itemretrievalrequest.h 2d0cc24 
>   server/src/storage/itemretrievalthread.h 5e2fbd3 
>   server/src/storage/itemretriever.h 3cac428 
>   server/src/storage/notificationcollector.h 5351787 
>   server/src/storage/parthelper.h 2d91b90 
>   server/src/storage/parttypehelper.h 38cb858 
>   server/src/storage/query.h f4f1ac0 
>   server/src/storage/querybuilder.h b380f93 
>   server/src/storage/querycache.h cff16b2 
>   server/src/storage/queryhelper.h 273db27 
>   server/src/storage/schema.h f0447d3 
>   server/src/storage/schematypes.h 449ecbf 
>   server/src/storage/selectquerybuilder.h a8c1ad2 
>   server/src/storage/storagedebugger.h a661ff7 
>   server/src/storage/transaction.h b31d093 
> 
> Diff: https://git.reviewboard.kde.org/r/118368/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/