Review Request 117975: Change libmaildir listNew and listCurrent functions to explicetely not sort QDir.entryList

Andras Mantia amantia at kde.org
Sun May 11 22:15:55 BST 2014


On Sunday, May 11, 2014 11:50:24 AM Martin Steigerwald wrote:
> > On May 5, 2014, 3:08 p.m., Sergio Luis Martins wrote:
> > > Commit to stable too ?
> > 
> > Laurent Montel wrote:
> >     Please wait after 4.13.1 it will tag the 8 may.
> >     Apply it in 4.13.2 if safe
> >     thanks
> > 
> > Martin Steigerwald wrote:
> >     Okay, will wait. I think its good if someone else than me actually
> >     also tests it. For me it works really nicely.
> Hi! So did anyone test with it? It works very well for me. I see higher I/O
> throughput on accessing folders, but I think thats just due to the fact
> that there is way less CPU overhead now. It will stat() mail files in
> random order instead of alphabetically now, I think. Depending on the
> filesystem implementation and the order in which those files will be
> created, this may make a difference – accessing in inode number order may
> help on some filesystems. In any case, subjectively I think it is way
> better than before. What do you experience?
> 
> So did anyone test and okay with committing to 4.13.2? How can I do it?
> Rebase my nosorting branch to 4.13.2 branch and then merge my nosorting
> branch with the two commits into 4.13.2 branch? I did so with my commits to
> master branch, so I think this would work.

I updated master after the commit and didn't see any bad sideeffects. Can't 
tell if it is faster or not.

Andras




More information about the kde-pim mailing list