[Kde-pim] Review Request 118408: Adding ability to subclass Fakeserver

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118408/#review58826
-----------------------------------------------------------


This review has been submitted with commit d04fcaa161c2d96ede53f1c701db7a3d5fa2b7c4 by Sandro Knauß to branch master.

- Commit Hook


On May 29, 2014, 6:46 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118408/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 6:46 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> For subclasses it is needed to have control over the received and expeced values of transmissions.
> 
> I used the FakeServer as parent for CyrusFakeServer available in kolab-utils[0], this class can reply cyrus log files directly.
> I would also be d'accord to push the complete CyrusFakeServer class upstream. But thinks this can be get dead code, 'cause nothing using this class.
> 
> [0] http://git.kolabsys.com/kolab-utils/tree/fbdaemon/tests/cyrusfakeserver.h?h=fbdaemon
> 
> 
> Diffs
> -----
> 
>   kimap/tests/kimaptest/fakeserver.h 009a2ad23a5322ab0a8fef7d6314e312d01d5133 
>   kimap/tests/kimaptest/fakeserver.cpp 9bd6018f002ce73af5856eb8e91656c9e343b302 
> 
> Diff: https://git.reviewboard.kde.org/r/118408/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/