[Kde-pim] Review Request 118093: Survive to no relevant capability being available

Kevin Ottens ervin at kde.org
Mon May 12 11:12:02 BST 2014



> On May 12, 2014, 9:59 a.m., Christian Mollekopf wrote:
> > This is fixed in master already, the unittest would be great though.

What? You fixed without the unit test first? :-p

OK, I'll upload a new patch with just the unit test shortly.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118093/#review57751
-----------------------------------------------------------


On May 12, 2014, 9:56 a.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118093/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 9:56 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> If the server had no relevant capability we'd end up stuck, the task never finishing.
> 
> 
> Diffs
> -----
> 
>   resources/imap/retrievecollectionmetadatatask.cpp da34087 
>   resources/imap/tests/testretrievecollectionmetadatatask.cpp 59d34fe 
> 
> Diff: https://git.reviewboard.kde.org/r/118093/diff/
> 
> 
> Testing
> -------
> 
> Unit test added.
> Used in production.
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list