[Kde-pim] Review Request 118329: CollectionFetchJob: ensure result() is the last signal emitted.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118329/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

CollectionFetchJob: ensure result() is the last signal emitted.

If we simply use delayedEmitResult() instead of emitResult() it is already
ensured that all collections are emitted before result, the whole flushing
not necessary. This also fixes the recursive fetch, where the collections
were not emitted before result, which is IMO a bug.
I added the required tests to ensure the job behaves like it should.


Diffs
-----

  akonadi/tests/collectionjobtest.cpp 298f4898d815e3a5228be56d9a9b48573d2ef2ff 
  akonadi/tests/collectionjobtest.h 63353c629256ab6c95bdfd92b05c3da5d057e669 
  akonadi/collectionfetchjob.cpp ae24a35f4b34444242e5a97bb1ea1881e8b9daa3 

Diff: https://git.reviewboard.kde.org/r/118329/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/