[Kde-pim] Review Request 118120: KHolidays: National holiday files for Bavaria and Germany

[Ettore Atalan]

> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de_de, line 51
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272765#file272765line51>
> >
> >     The Eisheiligen are written without "z" at the end:
> >         Mamertus 11. Mai
> >         Pankratius 12. Mai
> >         Servatius 13. Mai
> >         Bonifatius 14. Mai
> >         Sophia 15. Mai

Mamerz is the short form for Mamertus.
Pankraz is the short form for Pankratius.
Servaz is the short form for Servatius.
Bonifaz is the short form for Bonifatius.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de-by_de, line 79
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272764#file272764line79>
> >
> >     on wendsday ...

Okay.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de-by_de, line 31
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272764#file272764line31>
> >
> >     remove ":" at the beginning, to make it not a comment

Okay.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de_de, line 17
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272765#file272765line17>
> >
> >     Remove ":"

Okay.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de-by_de, line 82
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272764#file272764line82>
> >
> >     ... december 24 ...

Okay.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de_de, line 30
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272765#file272765line30>
> >
> >     I know this as "1./2. Weihnachtsfeiertag", but this may be dialect.

Changed it to "Weihnachtsfeiertag".


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de_de, line 64
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272765#file272765line64>
> >
> >     Wendsday before Totensontag:
> >     on wendsday before december 24 minus 32

Okay.


> On May 14, 2014, 11:30 a.m., Sandro Knauß wrote:
> > kholidays/holidays/plan2/holiday_de_de, line 67
> > <https://git.reviewboard.kde.org/r/118120/diff/1/?file=272765#file272765line67>
> >
> >     same day like totensonntag:
> >     on sunday before december 24 minus 28 days

Okay.


- Ettore


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118120/#review57912
-----------------------------------------------------------


On May 14, 2014, 3:52 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118120/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 3:52 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Ettore Atalan.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Upload diff on behalf of Ettore Atalan, see http://lists.kde.org/?l=kde-pim&m=139895732001805&w=2
> 
> 
> Diffs
> -----
> 
>   kholidays/holidays/plan2/holiday_de-by_de 20682df 
>   kholidays/holidays/plan2/holiday_de_de 3a0a9c4 
> 
> Diff: https://git.reviewboard.kde.org/r/118120/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/