[Kde-pim] Review Request 117769: Support for tag types + and fixed tag fetch by RID.

Christian Mollekopf chrigi_1 at fastmail.fm
Tue May 6 12:38:00 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117769/
-----------------------------------------------------------

(Updated May 6, 2014, 11:38 a.m.)


Review request for Akonadi.


Changes
-------

This uses now the default values as suggested. Omitting the type in TAGAPPEND results in the tag getting the default PLAIN value.


Repository: akonadi


Description
-------

Support for tag types + and fixed tag fetch by RID.

The type is stored a separate table and always returned when fetching a tag.
Additionally we're now picking the right result of the query as rid.


Diffs (updated)
-----

  CMakeLists.txt 39c6027d073effc016a90578516a0e1178bc5eac 
  server/src/connection.cpp 5889f44cfee6ea21ba1a87cbc639211c1c8a863d 
  server/src/handler/tagappend.cpp 1d0bfd40056ed80f2c0dcaf24d8dabad95020ba7 
  server/src/handler/tagfetchhelper.cpp 081eedbd262af32fdd9fd713c1e6fa1453aec410 
  server/src/storage/akonadidb.xml 6c3d25e06c62a5f321988cf163f8d88b487ea1f4 

Diff: https://git.reviewboard.kde.org/r/117769/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list