[Kde-pim] Review Request 118100: Make GETMETADATA RFC 5464 compatiple

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118100/#review57794
-----------------------------------------------------------


From to the rfc:
getmetadata       = "GETMETADATA" [SP getmetadata-options]
                                        SP mailbox SP entries
                          ; empty string for mailbox implies
                          ; server annotation.

getmetadata-options = "(" getmetadata-option
                                *(SP getmetadata-option) ")"

getmetadata-option = tagged-ext-label [SP tagged-ext-val]
                          ; tagged-ext-label and tagged-ext-val
                          ; are defined in [RFC4466].

maxsize-opt       = "MAXSIZE" SP number
                          ; Used as a getmetadata-option

That seems to say the command should look like:
GETMETADATA (MAXSIZE 10 DEPTH 1) mailbox (/shared/comment /private/comment)

So it seems the options should be in one pair of brackets instead of two.

Note that the examples given in the RFC are wrong according to the errata:
http://www.rfc-editor.org/errata_search.php?rfc=5464

The options should in fact come before the mailbox name (but they come after the mailbox in the MAXSIZE and DEPTH examples).

- Christian Mollekopf


On May 12, 2014, 3:11 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118100/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 3:11 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Make GETMETADATA RFC 5464 compatiple and "fixing" ANNOTATEMORE mode.
> 
> There were some issues, so the GETMETADATA command was not ok according to RFC 5464.
> The ANNOTATEMORE mode is only the draft of RFC 5464, so this is only a legacy mode.
> I would say, kimap uses http://tools.ietf.org/html/draft-daboo-imap-annotatemore-06.
> 
> 
> Diffs
> -----
> 
>   kimap/getmetadatajob.cpp 8c13fbb38c9d248fd3502a40e4ca3187b943b630 
>   kimap/tests/getmetadatajobtest.cpp 760aab341086be931c1b120df92ba37c20ac28c3 
> 
> Diff: https://git.reviewboard.kde.org/r/118100/diff/
> 
> 
> Testing
> -------
> 
> Adding tests to make sure that GETMETADATA is send in the correctly.
> Added tests for ANNOTATEMORE mode.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/