[Kde-pim] Review Request 116877: Make ItemFetchJob work for in Item whose remote ID is specified

[David Jarvie]

> On March 18, 2014, 6:19 p.m., Kevin Krammer wrote:
> > akonadi/itemfetchjob.cpp, line 191
> > <https://git.reviewboard.kde.org/r/116877/diff/1/?file=255188#file255188line191>
> >
> >     I know this has not changed, but I wonder if this should not return here?

A good point!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116877/#review53351
-----------------------------------------------------------


On March 19, 2014, 10:09 a.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116877/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 10:09 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Currently when an Item with only remote ID specified is supplied to the ItemFetchJob constructor, calling setCollection() to set its context does not (contrary to the apidox) work. In fact, setCollection() only works when fetching whole Collections, for which a separate constructor is provided. This patch makes setCollection(), and fetching by remote ID, work the way they are supposed to.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.cpp 93168c3 
> 
> Diff: https://git.reviewboard.kde.org/r/116877/diff/
> 
> 
> Testing
> -------
> 
> Tested with new KAlarm code.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/