[Kde-pim] Review Request 116500: Coding style fixes for ActionList.qml

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116500/#review51656
-----------------------------------------------------------



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36717>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36719>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36720>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36754>

    block braces around if/else bodies



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36755>

    block braces around if/else bodies



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36721>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36722>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36726>

    group anchors sub properties if there is more than one
    anchors {
        left: nameItem.right
        bottom: nameItem.top
    }



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36723>

    trailing whitespace



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36724>

    this looks like it is not indented far enough. can you check that this line is four spaced "deeper" then the line before?



ActionList.qml
<https://git.reviewboard.kde.org/r/116500/#comment36725>

    maybe move that to the other property assignemtns at the beginning of the element?


- Kevin Krammer


On March 1, 2014, 3:39 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116500/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 3:39 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Details at: 
> https://community.kde.org/Plasma/QMLStyle 
> 
> 
> Diffs
> -----
> 
>   ActionList.qml 837e793 
> 
> Diff: https://git.reviewboard.kde.org/r/116500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/