[Kde-pim] Review Request 116933: avoid splitting an UTF-8 encoded character in the middle of the encoded bytes according RFC 6350

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116933/
-----------------------------------------------------------

(Updated March 21, 2014, 4:56 p.m.)


Review request for KDEPIM-Libraries and Kevin Krammer.


Changes
-------

changes according Kevin


Bugs: 271859
    http://bugs.kde.org/show_bug.cgi?id=271859


Repository: kdepimlibs


Description
-------

the file format spec in RFC 6350 says:
http://tools.ietf.org/html/rfc6350#section-3.2
Line Delimiting and Folding

"Multi-octet characters MUST remain contiguous."

The current implementation would split anywhere.

My solution checks for UTF-8 encoding and moves only full encoding sequences to the next line.


Diffs (updated)
-----

  kabc/vcardparser/testroundtrip.qrc e5a6616 
  kabc/vcardparser/vcardparser.cpp ec8f272 

Diff: https://git.reviewboard.kde.org/r/116933/diff/


Testing
-------

added a new vcard testcase for the roundtrip test.
tested also manually with different line lengths


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/