[Kde-pim] Review Request 116841: do not double-encode vcard data and produce correct UTF-8

[Thomas Tanghus]

On Monday 17 March 2014 07:41 Martin Koller wrote:
> On Monday 17 March 2014 00:38:11 Thomas Tanghus wrote:
> > > The test vcard file is attached here. Maybe you could verify this with a
> > > different client than the KDE WebDav one ?
> > > I'm struggling with this already the whole day ...
> > > Shall I open a bug report on owncloud.org ?
> > 
> > I can't import that card from ownCloud web UI either.
> 
> Huh ? That's strange. I'm using 6.0.1 and it works fine

I did the mistake to save it from kate instead of from kmail :P

Sorry for the noise.

> 
> > The only way I could
> > make it sort of render, was with setting encoding to utf-8 in kate, and it
> > still says it contains invalid chars.
> 
> Yes, but that is correct. Don't get confused with the way vcard breaks the
> lines: It breaks after 75 chars, inserts \r\n and a blank for continuation
> line. In that case it breaks between two chars which form a UTF-8 sequence,
> therefore kate says illegal char, but the VCard parser joins the lines
> again BEFORE it converts the line back to unicode.
> 
> > I suppose it's the triangle symbol (I can't paste it in KMail, but tried
> > to
> > attach a screenie). Anybody knows what character that is?
> > 
> > I've re-attached the vCard and CC'ed to Evert Pot who's behind the Sabre
> > VObject library we use for parsing V* objects.
> > I do think that card is invalid, but I don't get any warnings when
> > importing it.
> 
> yes, as said above. don't get confused here. I also had to read the KDE
> vcard parser code to understand why the file contains "illegal" chars but
> still it works.
> 
> And I think the parser/converter does it correctly as it also breaks too
> long lines when they contain base64 encoded data, so this is like a
> "transfer encoding".

-- 
Med venlig hilsen / Best Regards

Thomas Tanghus
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/