[Kde-pim] Review Request 116504: Coding style fixes for ActiveActionMenuItemDelegate.qml

Kevin Krammer krammer at kde.org
Sun Mar 2 15:17:26 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116504/#review51659
-----------------------------------------------------------



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36730>

    trailing whitespace



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36732>

    check indentation, needs to be four spaces deeper then QML.NumberAnimation.
    same for next line



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36733>

    group anchors



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36734>

    group anchors



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36736>

    use separate lines for group sub properties. like for anchors.
    border {
    ....
    }



ActiveActionMenuItemDelegate.qml
<https://git.reviewboard.kde.org/r/116504/#comment36735>

    group anchors


- Kevin Krammer


On March 1, 2014, 3:48 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116504/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 3:48 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Details at: 
> https://community.kde.org/Plasma/QMLStyle 
> 
> 
> Diffs
> -----
> 
>   ActiveActionMenuItemDelegate.qml 73c6637 
> 
> Diff: https://git.reviewboard.kde.org/r/116504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list