[Kde-pim] Review Request 116839: akonadi: skip nepomuk feeder agent if baloo indexer is present

[Kevin Krammer]

> On March 16, 2014, 5:54 p.m., Kevin Krammer wrote:
> > server/control/agentmanager.cpp, line 523
> > <https://git.reviewboard.kde.org/r/116839/diff/1/?file=254517#file254517line523>
> >
> >     that is quite a hack
> >     Akonadi server stuff should not be hardcoding such things.
> >     Can't you set XDG_DATA_DIRS to not include /usr/share?
> 
> David Faure wrote:
>     No, I want to be able to use firefox, openoffice etc....
>     
>     Surely I can't be the only one compiling KDE into its own prefix while having a distro KDE --- and having /usr/share in XDG_DATA_DIRS to get everything else in my KDE session.
>     
>     (The same problem would happen to people who install into the same custom builddir while upgrading KDE, too, unlike my inst/kde4.13 prefix)
>     
>     I know akonadi shouldn't know about these agents in theory, but it's the only place where this can go, isn't it?
>     I can't see what harm this actually creates in practice. The alternative is some sort of config file based agent exclusion... but by the time baloo's agent starts it might be too late.
>     
>     Note that the same happened when nepomuk_{email,contact,calendar}_feeder got merged into a single feeder. For a while I had all four running because of such a migration issue, so this isn't a one-time issue and might happen again.

well, it is only temporary, we need to remember to revert this.

I really don't see the problem with XDG_DATA_DIRS though. I have a whole set of different environment variable values for KDE master (actually one set per branch):
KDEDIRS, XDG_DATA_DIRS, KDEHOME, KDETMP, KDEVARTMP, XDG_DATA_HOME, XDG_CONFIG_HOME
Even running that in a separate user account.

Never had any problem with firefox or openoffice, etc.

If we really need all those hacks (I think we still have some other KDE specific hack in there somewhere) then we should have a KDE branch that rebased on master automatically.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116839/#review53082
-----------------------------------------------------------


On March 16, 2014, 5:36 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116839/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 5:36 p.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> akonadi: skip nepomuk feeder agent if baloo indexer is present
> 
> On my system nepomuk feeder was found in /usr/share/akonadi/agents
> and baloo was found in /d/kde/inst/kde4.13/share/akonadi/agents,
> so nepomuk feeder was started even though it's not part of 4.13, and it
> crashed, got restarted, crashed...
> 
> 
> Diffs
> -----
> 
>   server/control/agentmanager.cpp ab383577f6ab6c22c18b0bdff75f21661544e1c0 
> 
> Diff: https://git.reviewboard.kde.org/r/116839/diff/
> 
> 
> Testing
> -------
> 
> restarted akonadi, saw debug line, nepomuk feeder agent not started.
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/