[Kde-pim] Review Request 116558: Add KAccounts support to the dav resource

[Thomas Tanghus]

I don't understand Akonadi enough to grasp what's going on, but if you decide 
which kind of *DAV it is by looking at the URL there are many potential 
misses.

You can have WebDAV, CalDAV and CardDAV end-points at any URL - even the same.

   if (urls.at( i ).contains( "caldav" )

On Monday 10 March 2014 19:05 Dan Vrátil wrote:
> 
> Ship it!
> 
> 
> I don't understand DAV enough to be able to tell whether the new code is
> correct, but it looks OK to me and it will not impact resource
> functionality when using the standard authentication methods (via
> resource's configuration dialog), so the resource will work even if the new
> code has some bugs.
> 
> - Dan Vrátil
> 
> On March 6, 2014, 8:55 p.m., Àlex Fiestas wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/116558/
> > -----------------------------------------------------------
> > 
> > (Updated March 6, 2014, 8:55 p.m.)
> > 
> > 
> > Review request for KDEPIM, Release Team and Grégory Oestreicher.
> > 
> > 
> > Repository: kdepim-runtime
> > 
> > 
> > Description
> > -------
> > 
> > If compiled with KAccounts support and configure to use it, the resource
> > will fetch credentials and host using libaccounts in order to build the
> > urls.
> > 
> > Support for "editing" is not done, that will be done in 4.14 since it
> > requires better kaccounts-integration.
> > 
> > To the release team, I would like to add this change to 4.13, it won't do
> > anything except compiled with libaccounts and even so only if the
> > resource is configured to use it.
> > 
> > 
> > Diffs
> > -----
> > 
> >   resources/dav/resource/CMakeLists.txt 14675bc
> >   resources/dav/resource/davgroupwareresource.desktop 2342a01
> >   resources/dav/resource/davgroupwareresource.kcfg 2d25371
> >   resources/dav/resource/settings.h e264866
> >   resources/dav/resource/settings.cpp 12f84cc
> > 
> > Diff: https://git.reviewboard.kde.org/r/116558/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Àlex Fiestas
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

-- 
Med venlig hilsen / Best Regards

Thomas Tanghus
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/