[Kde-pim] Review Request 116815: Optimize the address parsing by caching already parsed addresses

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116815/#review53009
-----------------------------------------------------------


A couple of things:
- the access to the hash is not thread safe
- the code doesn't seem to add anything to the cache
- it doesn't have any limitation on used memory, see QCache

- Kevin Krammer


On March 15, 2014, 5:02 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116815/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 5:02 p.m.)
> 
> 
> Review request for KDEPIM, Dan Vrátil and Vishesh Handa.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Profiling mail indexing showed that parsing the address line was taking up most time. Further checking showed that each address is parsed, also if it was already parsed. So i simply added a cache in between which means that addresses are only parsed if not parsed before. This should speed up indexing significantly.
> 
> In my benchmarks indexing was twice as fast as opposed to before this patch. But on git master i'm getting wildly different results. Still faster, but just about 20%.
> 
> 
> Diffs
> -----
> 
>   plugins/akonadi_serializer_mail.cpp a6ac4b8 
> 
> Diff: https://git.reviewboard.kde.org/r/116815/diff/
> 
> 
> Testing
> -------
> 
> All tests pass just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/