[Kde-pim] Review Request 116977: mbox: don't complain about a normal situation

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116977/
-----------------------------------------------------------

(Updated March 22, 2014, 10:44 p.m.)


Review request for KDEPIM and Kevin Krammer.


Summary (updated)
-----------------

mbox: don't complain about a normal situation


Bugs: 287394
    http://bugs.kde.org/show_bug.cgi?id=287394


Repository: kdepim-runtime


Description
-------

An mbox resource with file watching only makes sense when some other program changes that mbox file.
Why would one else want to watch for file changes ?

The current situation always throws an error message (or multiple) to the user whenever the mbox resource detects
that the mbox file was changed - which is expected.

Also, currently a "backup file" was written, obviously to avoid "data loss" - but that implementation never worked
as the backup file was truncated to 0-bytes. Nevertheless, the backup file would be useless, even if written
correctly, and would just fill up the disk, as no normal user would know what to do with that file -
especially as it gets written _every time_ a new mail arrives.

This patch does:
- When file watching is enabled, avoid to write the backup file.
- do not complain that the file was changed from an external program when the baseclass detects a changed hash
  (this was called twice). The baseclass already emits a warning when it does the backup


Diffs
-----

  resources/mbox/mboxresource.h 67b5b0a 
  resources/mbox/mboxresource.cpp 36aef8b 
  resources/shared/singlefileresource.h 9f7c24e 
  resources/shared/singlefileresourcebase.h 983ddbe 
  resources/shared/singlefileresourcebase.cpp b0f736a 

Diff: https://git.reviewboard.kde.org/r/116977/diff/


Testing
-------

yes


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/