[Kde-pim] Review Request 117008: Avoid setting the Agent online if it needs network but there is none

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117008/
-----------------------------------------------------------

(Updated March 25, 2014, 7:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Bugs: 329857
    http://bugs.kde.org/show_bug.cgi?id=329857


Repository: kdepimlibs


Description
-------

Without this patch an agent is online initially and only reacts to subsequent,
    online status changes. This cause for example the imap resource to go online
    when started without network connection (resulting in a wrong initial status),
    and as the imap resource tried to connect and failed, it set itself to offline,
    resulting in it not reacting to the network becoming available.
    
    With this patch all network detection code can be removed from the imap resource
    and it properly reacts to network changes.


Diffs
-----

  akonadi/agentbase.cpp 373574c 

Diff: https://git.reviewboard.kde.org/r/117008/diff/


Testing
-------

Tested with the imap resource.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/