[Kde-pim] Review Request 116291: Coding Style for item_p.h
Kevin Krammer
krammer at kde.org
Sat Mar 1 23:56:13 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116291/#review51544
-----------------------------------------------------------
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36381>
: onto next line?
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36382>
maybe remove the excess white spacing between const and opening brace?
same for the next couple of methods
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36383>
here and following methods the excess space seems to be between closing argument parentheses and const
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36384>
and a variant with excess space between type and method name
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36385>
block braces
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36386>
block braces
akonadi/item_p.h
<https://git.reviewboard.kde.org/r/116291/#comment36387>
block braces
- Kevin Krammer
On Feb. 27, 2014, 5:38 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116291/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 5:38 p.m.)
>
>
> Review request for KDEPIM-Libraries and Dan Vrátil.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> Details can be seen at:
> http://techbase.kde.org/Policies/Kdepim_Coding_Style
>
>
> Diffs
> -----
>
> akonadi/item_p.h fd865a4
>
> Diff: https://git.reviewboard.kde.org/r/116291/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list