[Kde-pim] Review Request 116298: Coding Style for itemfetchjob.cpp

[Guy Maurel]

> On March 9, 2014, 3:41 p.m., Kevin Krammer wrote:
> > akonadi/itemfetchjob.cpp, line 85
> > <https://git.reviewboard.kde.org/r/116298/diff/1-2/?file=250722#file250722line85>
> >
> >     that should be on the line of the method signature, i.e. after const.
> >     It is a c++ method annotation we can add in Qt5
> >

The problem is caused by astyle because the { is at the end of the line.
We need to take care of this *before* the use of astyle.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116298/#review52449
-----------------------------------------------------------


On March 15, 2014, 6:01 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116298/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 6:01 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.cpp ca67e88 
> 
> Diff: https://git.reviewboard.kde.org/r/116298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/