[Kde-pim] Review Request 116686: Fix replacement for deprecated Event::setHasEndDate()

David Jarvie djarvie at kde.org
Mon Mar 10 10:19:29 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116686/
-----------------------------------------------------------

(Updated March 10, 2014, 10:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

If the call recommended in the apidox is used instead of the deprecated Event::setHasEndDate(false), it will currently not have the same effect, since setDtEnd() only changes d->mHasEndDate when the supplied KDateTime is valid. It also needs to be changed when the KDateTime is invalid.

This patch also needs to be applied to the 4.12 and 4.13 branches.


Diffs
-----

  kcalcore/event.h 0aaaa02 
  kcalcore/event.cpp 67d5cc0 

Diff: https://git.reviewboard.kde.org/r/116686/diff/


Testing
-------


Thanks,

David Jarvie

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list