[Kde-pim] Akonadi Commandline Interface Project

[Kevin Krammer]

On Monday, 2014-03-03, 17:02:53, Bhaskar Kandiyal wrote:
> On Monday 03 March 2014 03:21 AM, Kevin Krammer wrote:
> > On Monday, 2014-03-03, 02:24:10, Bhaskar Kandiyal wrote:
> >> Hi!
> >> 
> >> I've made a few changes to the application [1], mainly:
> >> 
> >> * Moved QCoreApplication initialization to main() - Should I send a
> >> patch for review?
> > 
> > I would suggest to also rename CommandRunner::exec() to
> > CommandRunner::start(), it no longer has exec() behavior.
> > 
> > Also the main idea of the move was to create the application object before
> > the runner.
> 
> Ah, I kind of missed the point there, sorry! I've made the changes now :)

Yes, that looks a lot like what I had in mind :)

Can you create a review request for that?
Reviewers myself and Jonathan (no need to add the kdepim list).

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140303/16b3538c/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/