[Kde-pim] Review Request 117140: ItemSync: Only fetch the items that are actually required.

Christian Mollekopf chrigi_1 at fastmail.fm
Sat Mar 29 23:10:36 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117140/
-----------------------------------------------------------

(Updated March 29, 2014, 11:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

ItemSync: Only fetch the items that are actually required.

ItemSync used to fetch *all* items during *every* sync, which is in most cases
completely unnecessary (at least for incremental sync). This patch delays the
fetch of items until we know which ones we need, and then only fetches the
required ones (usually none), resulting in an IMAP sync going from 10s 100%,
to a couple of seconds 1% cpu.


Diffs
-----

  akonadi/itemsync.cpp 05ee3d04a5b94c85abcab27ebc638e57b6a63d41 

Diff: https://git.reviewboard.kde.org/r/117140/diff/


Testing
-------

Running it locally, unittest passes.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list