[Kde-pim] Review Request 115846: kontact summary view

[Eugenio Accorsi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/
-----------------------------------------------------------

(Updated March 13, 2014, 4:08 p.m.)


Review request for KDEPIM.


Changes
-------

this just fix 278956, I used a different approach to fetch the events because previous one does not work with recurrences. also this method does not fetch all events from all calendars.


Bugs: 278956
    http://bugs.kde.org/show_bug.cgi?id=278956


Repository: kdepim


Description
-------

since i use kontact very often i tried to make the summary view work as expected.
the only problem with this patch is the special event plugin.
maybe someone with better experience with akonadi can steer me in the right direction..
i changed the old implementation because it doesn't work for every contact.


Diffs (updated)
-----

  kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
  kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 

Diff: https://git.reviewboard.kde.org/r/115846/diff/


Testing
-------

in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
i tried also with master but it does not find any contacts.
the summary event plugin works as expected.


Thanks,

Eugenio Accorsi

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/