[Kde-pim] Review Request 116815: Optimize the address parsing by caching already parsed addresses

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116815/
-----------------------------------------------------------

(Updated March 15, 2014, 9:47 p.m.)


Review request for KDEPIM, Dan Vrátil and Vishesh Handa.


Changes
-------

I went for .value() and .contains() rather then iterators. Mainly because this is far more readable.
This time it does write ;)


Repository: kdepim-runtime


Description
-------

Profiling mail indexing showed that parsing the address line was taking up most time. Further checking showed that each address is parsed, also if it was already parsed. So i simply added a cache in between which means that addresses are only parsed if not parsed before. This should speed up indexing significantly.

In my benchmarks indexing was twice as fast as opposed to before this patch. But on git master i'm getting wildly different results. Still faster, but just about 20%.


Diffs (updated)
-----

  plugins/akonadi_serializer_mail.cpp a6ac4b8 

Diff: https://git.reviewboard.kde.org/r/116815/diff/


Testing
-------

All tests pass just fine.


Thanks,

Mark Gaiser

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/