[Kde-pim] Review Request 117163: Fix 327549 hide encrypted.asc from Thunderbird encrypted messages.

[Sandro Knauß]

> On March 31, 2014, 7:34 a.m., Laurent Montel wrote:
> > messagecore/tests/stringutiltest.cpp, line 349
> > <https://git.reviewboard.kde.org/r/117163/diff/1/?file=258089#file258089line349>
> >
> >     Perhaps add:
> >     QVERIFY( !StringUtil::isCryptoPart( QLatin1String("application"), QLatin1String("foo"), QLatin1String("encrypted.asc) ) );
> >     
> >     too

thx for this additional test. It showes my a brace typo.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117163/#review54654
-----------------------------------------------------------


On March 31, 2014, 8:39 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117163/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 8:39 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 327549
>     http://bugs.kde.org/show_bug.cgi?id=327549
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> simply thunderbird names the attachment, that is actually the encrypted
> message filename=encrypted.asc; kmail names it msg.asc.
> 
> 
> Diffs
> -----
> 
>   messagecore/utils/stringutil.cpp 3a54ab38b37cfad8e4d0b6182800c4870828108c 
>   messagecore/tests/stringutiltest.cpp ff5bdc2486a5574537527ce542af1977e9bcadec 
> 
> Diff: https://git.reviewboard.kde.org/r/117163/diff/
> 
> 
> Testing
> -------
> 
> test with a message from thunderbird and run make test.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/