[Kde-pim] Review Request 116508: Coding style fixes for AgentStatusIndicator.qml

Kevin Krammer krammer at kde.org
Sun Mar 2 17:39:02 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116508/#review51687
-----------------------------------------------------------



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36786>

    else on the same line as the closing brace of the if, i.e.
    } else {



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36787>

    same here



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36790>

    indentation too deep, should align with else



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36788>

    same here



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36791>

    indentation too deep, should align with else



AgentStatusIndicator.qml
<https://git.reviewboard.kde.org/r/116508/#comment36789>

    same here


- Kevin Krammer


On March 2, 2014, 5:35 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116508/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 5:35 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Details at: 
> https://community.kde.org/Plasma/QMLStyle 
> 
> 
> Diffs
> -----
> 
>   AgentStatusIndicator.qml 6683293 
> 
> Diff: https://git.reviewboard.kde.org/r/116508/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list