[Kde-pim] Review Request 115817: when connection to server fails, set it offline and retry later

[Martin Koller]

> On March 16, 2014, 12:14 p.m., Kevin Krammer wrote:
> > resources/dav/resource/davgroupwareresource.cpp, line 744
> > <https://git.reviewboard.kde.org/r/115817/diff/3/?file=254423#file254423line744>
> >
> >     any specific reason the local message is no longer part of the error message?

yes. The job error string already contains this information, so it was duplicate information.
E.g.:
DavItemCreateJob::davJobFinished( KJob *job )
...
    setErrorText( i18n( "There was a problem with the request. The item has not been created on the server.\n"
                        "%1 (%2).", err, responseCode ) );


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115817/#review53044
-----------------------------------------------------------


On March 16, 2014, 11:55 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115817/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 11:55 a.m.)
> 
> 
> Review request for KDEPIM, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> The DAV resource would discard item modifications (add, change, remove) whenever it does not currently reach the DAV server,
> which can happen when I'm connected to the company network but have a DAV server in my home network only.
> 
> This patch makes sure to set the resource to temporary offline in these cases and retries to go online at configured check interval.
> 
> 
> Diffs
> -----
> 
>   resources/dav/resource/davgroupwareresource.h a514c94 
>   resources/dav/resource/davgroupwareresource.cpp b8b2f74 
> 
> Diff: https://git.reviewboard.kde.org/r/115817/diff/
> 
> 
> Testing
> -------
> 
> Tested against my owncloud-6 server
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/