[Kde-pim] Review Request 116267: Coding Style for entitytreemodel.cpp

Kevin Krammer krammer at kde.org
Sat Mar 1 22:20:54 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116267/#review51518
-----------------------------------------------------------



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36278>

    should probably be on the previous line, most likely causes the intentation error on the next two lines



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36279>

    indentation way too deep



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36280>

    block braces



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36281>

    block braces



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36282>

    wrong indentation level (closing brace of outer if)



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36283>

    wrong indentation level (closing brace of case)



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36284>

    wrong indentation level (closing brace of outer if)



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36285>

    wrong indentation level (closing brace of case)



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36286>

    space after & operator



akonadi/entitytreemodel.cpp
<https://git.reviewboard.kde.org/r/116267/#comment36287>

    space after & operator


- Kevin Krammer


On Feb. 27, 2014, 5:35 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116267/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 5:35 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel.cpp fca1cad 
> 
> Diff: https://git.reviewboard.kde.org/r/116267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list