[Kde-pim] Review Request 116826: add a new method setTemporaryOffline() to temporarily halt an agent to restart after some timeout

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116826/#review53042
-----------------------------------------------------------


Looks good to me but I'd say we wait for another additional opinion. After all this is library API change


akonadi/agentbase.h
<https://git.reviewboard.kde.org/r/116826/#comment37341>

    online again after a given time



akonadi/agentbase.h
<https://git.reviewboard.kde.org/r/116826/#comment37342>

    maybe add a small code snippet as an example
    
    @code
    // the code you have in the dav resourc
    @endcode



akonadi/agentbase.h
<https://git.reviewboard.kde.org/r/116826/#comment37343>

    s/resource/agent/


- Kevin Krammer


On March 16, 2014, 11:38 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116826/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 11:38 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> as described in the review request 115817 a resource which detects that it can currently not continue to work correctly
> shall set itself temporarily to offline and shall retry to continue with the pending actions after some timeout.
> 
> This patch adds a new method setTemporaryOffline() to agentbase for this functionality.
> 
> 
> Diffs
> -----
> 
>   akonadi/agentbase.h 4671c80 
>   akonadi/agentbase.cpp 4e51824 
>   akonadi/agentbase_p.h 3ead634 
> 
> Diff: https://git.reviewboard.kde.org/r/116826/diff/
> 
> 
> Testing
> -------
> 
> with the DAV resource against an owncloud 6 Server
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/