[Kde-pim] Review Request 116841: do not double-encode vcard data and produce correct UTF-8

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116841/#review53137
-----------------------------------------------------------


This review has been submitted with commit d1e14bb84e626a6a61a7e4771a78abe25820ef79 by Martin Koller to branch KDE/4.12.

- Commit Hook


On March 16, 2014, 8:16 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116841/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 8:16 p.m.)
> 
> 
> Review request for KDEPIM, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> The DAV resource creates an addressee VCARD by using KABC::VCardConverter which already delivers UTF-8 when creating a V3.0 vcard.
> In an attempt to fix KDE bug https://bugs.kde.org/show_bug.cgi?id=310137 a wrong conversion from UTF-8 to finally again UTF-8
> was introduced (6b829e2..762797c)
> This patch avoids the wrong conversion by just delivering directly the UTF-8 data.
> 
> With this patch applied, simple (short) names containing Umlauts can now correctly be created on the owncloud server.
> 
> However, I can still reproduce the original bug #310137, but analyzing this further, it seems that this is a bug
> in the owncloud WebDAV server, which obviously does not deal correctly with continuation lines. Importing such a 3.0 VCARD file
> via the web interface works in owncloud so it must be a bug in the WebDAV part of owncloud.
> 
> 
> Diffs
> -----
> 
>   resources/dav/common/davutils.cpp f38836a 
> 
> Diff: https://git.reviewboard.kde.org/r/116841/diff/
> 
> 
> Testing
> -------
> 
> against my owncloud-6 server.
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/