[Kde-pim] Review Request 117133: Make ItemSync::Private inherit from JobPrivate.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117133/
-----------------------------------------------------------

(Updated March 28, 2014, 6:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Make ItemSync::Private inherit from JobPrivate.

i.e. port it to Q_Q and Q_D. This makes it match ItemFetchJob, and
makes it possible to (in a later commit) reimplement the virtual method
JobPrivate::jobDebuggingString().


Diffs
-----

  akonadi/itemsync.h 037f2b25207f789942cdb27aaebd9f4306bc9ddb 
  akonadi/itemsync.cpp 05ee3d04a5b94c85abcab27ebc638e57b6a63d41 

Diff: https://git.reviewboard.kde.org/r/117133/diff/


Testing
-------

Recompiled, restarted kmail, no crash, email sync appears to work. Not that I really know when ItemSync is actually triggered (adding a debug string is exactly for that: to find out more about when/how/for what it gets triggered).


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/