[Kde-pim] Review Request 116500: Coding style fixes for ActionList.qml

Abhijeet Nikam connect08nikam at gmail.com
Sun Mar 2 17:42:17 GMT 2014



> On March 2, 2014, 5:25 p.m., Kevin Krammer wrote:
> > ActionList.qml, line 56
> > <https://git.reviewboard.kde.org/r/116500/diff/1-2/?file=251216#file251216line56>
> >
> >     "else" on same line as the closing brace of "if"

Is something wrong in that?

It is an if else statement, so according to me, it will be:

if {

}

else {

}


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116500/#review51684
-----------------------------------------------------------


On March 2, 2014, 5:13 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116500/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 5:13 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Details at: 
> https://community.kde.org/Plasma/QMLStyle 
> 
> 
> Diffs
> -----
> 
>   ActionList.qml 837e793 
> 
> Diff: https://git.reviewboard.kde.org/r/116500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list