[Kde-pim] Review Request 118534: Add "At start" to incidence editor alarms presets and improve translations

Sandro Knauß knauss at kolabsys.com
Thu Jun 5 00:01:36 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118534/#review59251
-----------------------------------------------------------



incidenceeditor-ng/alarmpresets.cpp
<https://git.reviewboard.kde.org/r/118534/#comment41252>

    add also i18ncp for minute, minutes. see also line 123.


- Sandro Knauß


On June 4, 2014, 4:44 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118534/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 4:44 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I often want to have an alarm for event or todo when the event starts (usually IRC meetings, or do-this-thing-now kind of events) and having to add it manually is annoying, so this patch adds "At start" to the alarm presets in incidence editor.
> 
> This patch also fixes use of singular and plural for other presets ("1 hours before start" => "1 hour before start", etc.)
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/alarmpresets.cpp 368e311 
> 
> Diff: https://git.reviewboard.kde.org/r/118534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list