[Kde-pim] Review Request 118634: Coding Style for preprocessormanager.cpp resourcemanager.cpp response.cpp storagejanitor.cpp tracer.cpp utils.cpp

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118634/#review59666
-----------------------------------------------------------


The preprocessormanager.cpp file is broken, looks like your script is misinterpreting "Class::method():" strings in akDebug()/qWarning() calls as constructors and eats the entire warning message


server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41569>

    The qWarning() has disappeared here?



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41570>

    This shouldn't be here too



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41571>

    Same as above



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41576>

    Missing qWarning



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41575>

    Missing akDebug



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41573>

    Missing qWarning



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41574>

    Missing qWarning



server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/118634/#comment41572>

    Missing qWarning here


- Dan Vrátil


On June 10, 2014, 11:30 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118634/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 11:30 a.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   server/src/preprocessormanager.cpp 517a55a 
>   server/src/resourcemanager.cpp e7c14f8 
>   server/src/response.cpp d822cd9 
>   server/src/storagejanitor.cpp effbbf7 
>   server/src/tracer.cpp 307a187 
>   server/src/utils.cpp cb0e091 
> 
> Diff: https://git.reviewboard.kde.org/r/118634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/